change defaults for access config
#5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The default value of `access` is now `public`
|
closes npm/statusboard#508 |
graph TB
subgraph "Public package"
public-package["package is public"]-->public-default-publish["publish"];
public-default-publish-->public-package;
public-package-->public-public-publish["publish --access=public"];
public-public-publish-->public-package;
public-package-->public-restricted-publish["publish --access=restricted"];
end
subgraph "Restricted package"
public-restricted-publish-->restricted-package;
restricted-package["package is restricted"]-->restricted-default-publish["publish"];
restricted-default-publish-->restricted-package;
restricted-package-->restricted-restricted-publish["publish --access=restricted"];
restricted-restricted-publish-->restricted-package;
restricted-package-->restricted-public-publish["publish --access=public"];
restricted-public-publish-->public-package;
end
|
wraithgar
force-pushed
the
gar/access-public
branch
from
dd893e0
to
dd62db1
Compare
|
found 20 benchmarks with statistically significant performance improvements
timing results
|
lukekarrys
approved these changes
Sep 29, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is two commits, one the breaking change to libnpmpublish, and the other a docs/logging update for the cli to be telling folks the truth. Please rebase/merge.
public